Грейд разработчика приходит с годами, но иногда годы приходят одни: зачем вам код-ревью
```python
capitals = ['Москва', 'Лондон', 'Париж']
for i in capitals:
...
``` ```python
capitals = ['Москва', 'Лондон', 'Париж']
for capital in capitals:
…
```
```python
def download_image_and_upload_it_to_telegram(url, tg_token):
...
``` ```python
def download_image(url):
...
def upload_image_to_telegram(tg_token):
...
``` ```python
def extract_salaries(vacancies):
...
def calculate_statistics(vacancies):
salaries = extract_salaries(vacancies)
average_salary = int(sum(salaries) / len(salaries)) if salaries else 0
...
def main():
...
statistics = ...
vacancies = ...
statistics[language] = calculate_statistics(vacancies)
...
``` ```python
def extract_salaries(vacancies):
...
def calculate_statistics(vacancies, salaries):
average_salary = int(sum(salaries) / len(salaries)) if salaries else 0
...
def main():
...
statistics = ...
vacancies = ...
salaries = extract_salaries(vacancies)
statistics[language] = calculate_statistics(vacancies, salaries)
...
``` ```python
numbers = [...]
even_numbers = []
for number in numbers:
if number % 2 == 0:
even_numbers.append(number)
``` ```python
numbers = [...]
even_numbers = [num for num in numbers if num % 2 == 0]
``` from environs import Env
def main():
env = Env()
env.read_env()
SECRET_KEY = env.str('SECRET_KEY', 'value_if_secret_key_is_empty')
from environs import Env
def main():
env = Env()
env.read_env()
SECRET_KEY = env.str('SECRET_KEY') ```python
not_unique_numbers = [1, 1, 2, 3, 1, 4, 3, ...]
unique_numbers = [5]
for number in not_unique_numbers:
if number not in unique_numbers:
unique_numbers.append(number)
```
```python
not_unique_numbers = [1, 1, 2, 3, 1, 4, 3, ...]
unique_numbers = {5}
unique_numbers = set(not_unique_numbers).union(unique_numbers)
```
```python
def calculate_fibonacci(num):
if num <= 1:
return num
return calculate_fibonacci(num - 1) + calculate_fibonacci(num - 2)
print(calculate_fibonacci(100))
```
```python
import functools
@functools.lru_cache(maxsize=None)
def calculate_fibonacci(num):
if num <= 1:
return num
return calculate_fibonacci(num - 1) + calculate_fibonacci(num - 2)
print(calculate_fibonacci(100))
```
```python
authors = Author.objects.all()
for author in authors:
books = author.books.all()
print(f'Автором {author.name} написано книг: {books.count()} шт.')
```
```python
def display_authors_and_books_optimized():
authors = Author.objects.prefetch_related('books').all()
for author in authors:
print(f'Автором {author.name} написано книг: {len(author.books.all())} шт.')
```
```python
with open("large_file.txt", "r") as file:
lines = file.readlines()
for line in lines:
do_something(line)
``` ```python
with open("large_file.txt", "r") as file:
for line in file:
do_something(line)
```